Add flag to enable LLVM backend debugging#3207
Merged
rv-jenkins merged 2 commits intodevelopfrom Mar 2, 2023
Merged
Conversation
Baltoli
force-pushed
the
kompile-debug-flag
branch
from
24c53d4 to
1b77b7d
Compare
radumereuta
approved these changes
Mar 2, 2023
5 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old syntax for enabling debug support was a bit clunky and prone to typos / errors (e.g. I flagged runtimeverification/llvm-backend#666 as an issue without realising that the error I was seeing was due to using
-O0rather than-O1).This PR adds a new flag to
kompile(--enable-llvm-debug) that abstracts the debugger invocation; internally, it just passes-g -O1to Clang as per the old flag.I plan to follow this up at some point with an integration test for the debugger, but I haven't quite figured out the ergonomics of doing so.