Skip to content

Introducing the hs-backend-booster to K Framework#3475

Merged
rv-jenkins merged 36 commits intodevelopfrom
hs-backend-booster-integration
Jul 10, 2023
Merged

Introducing the hs-backend-booster to K Framework#3475
rv-jenkins merged 36 commits intodevelopfrom
hs-backend-booster-integration

Conversation

@Robertorosmaninho
Copy link
Copy Markdown
Collaborator

@Robertorosmaninho Robertorosmaninho commented Jun 20, 2023

This PR introduces the Haskell Backend Booster to the K Framework repository!
Fixes #3470 with:

  • Clone the booster repo
  • Build with stack build in a similar way to haskell-backend/pom.xml
  • Modify the k-distribution/src/main/assembly/bin.xml to look for the appropriate binaries using the assemblies path.
  • Add a CI test that the booster is launchable with the installed Ubuntu package.

Adding the `hs-backend-booster` as a maven project
Comment thread k-distribution/src/main/assembly/bin.xml
@radumereuta radumereuta requested a review from dwightguth June 20, 2023 11:54
@Robertorosmaninho Robertorosmaninho requested a review from a team as a code owner June 20, 2023 14:11
Comment thread .github/workflows/Dockerfile.stack-deps Outdated

ENV LC_ALL=C.UTF-8
ADD --chown=$USER:$GROUP hs-backend-booster/src/main/native/hs-backend-booster/stack.yaml /home/$USER/.tmp-booster/
ADD --chown=$USER:$GROUP hs-backend-booster/src/main/native/hs-backend-booster/hs-backend-booster.cabal /home/$USER/.tmp-booster/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use a *.cabal file, instead we use package.yaml in the booster

@goodlyrottenapple
Copy link
Copy Markdown
Contributor

we need to do this for the booster in nix:

k/nix/k.nix

Lines 22 to 23 in ccd2656

"-Dllvm.backend.skip=true"
"-Dhaskell.backend.skip=true"

namely, disable building of the booster via maven, since we manually build and link the booster in nix.

@Robertorosmaninho Robertorosmaninho linked an issue Jun 20, 2023 that may be closed by this pull request
jberthold
jberthold previously approved these changes Jun 20, 2023
Copy link
Copy Markdown
Collaborator

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radumereuta
Copy link
Copy Markdown
Contributor

radumereuta commented Jun 22, 2023

From Dwight:
Try to build the Debian package on your local machine and see why it doesn't work.
To build the package: dpkg build-package (approximate)
Inspect the directory structure and see what's missing.

We have to make sure that we're testing the booster on all distros.

@Robertorosmaninho
Copy link
Copy Markdown
Collaborator Author

Do not automerge: NixOS 23.05 not working with this branch.

Copy link
Copy Markdown
Contributor

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread hs-backend-booster/pom.xml Outdated
@rv-jenkins rv-jenkins merged commit 3f1fead into develop Jul 10, 2023
@rv-jenkins rv-jenkins deleted the hs-backend-booster-integration branch July 10, 2023 23:02
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include booster backend in pom.xml build

7 participants