Skip to content

Remove some old unused attributes#3578

Merged
rv-jenkins merged 4 commits intodevelopfrom
remove-attributes
Aug 15, 2023
Merged

Remove some old unused attributes#3578
rv-jenkins merged 4 commits intodevelopfrom
remove-attributes

Conversation

@gtrepta
Copy link
Copy Markdown
Contributor

@gtrepta gtrepta commented Aug 14, 2023

No description provided.

@gtrepta gtrepta marked this pull request as ready for review August 15, 2023 00:19
Comment on lines -186 to -194
final val CIRCULARITY = Key("circularity", KeyType.BuiltIn)
final val COLOR = Key("color", KeyType.BuiltIn)
final val COLORS = Key("colors", KeyType.BuiltIn)
final val COMM = Key("comm", KeyType.BuiltIn)
final val CONCRETE = Key("concrete", KeyType.BuiltIn)
final val CONSTRUCTOR = Key("constructor", KeyType.BuiltIn)
final val CONTEXT = Key("context", KeyType.BuiltIn)
final val COOL = Key("cool", KeyType.BuiltIn)
final val DEPENDS = Key("depends", KeyType.BuiltIn)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

circularity and depends should be kept - they're not in use yet but are under development

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehildenb
Copy link
Copy Markdown
Member

Other than keeping circularity and depends, it looks good. I would ask @dwightguth to also have a look though, maybe some of these attributes mean something for LLVM backend.

@gtrepta gtrepta self-assigned this Aug 15, 2023
@dwightguth
Copy link
Copy Markdown
Contributor

Looks good. The test failure is a known transient issue, just rerun the tests.

@rv-jenkins rv-jenkins merged commit 86f9af7 into develop Aug 15, 2023
@rv-jenkins rv-jenkins deleted the remove-attributes branch August 15, 2023 18:42
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants