Fix Java 19#3584
Merged
dwightguth merged 5 commits intodevelopfrom Aug 18, 2023
Merged
Conversation
dwightguth
requested review from
Robertorosmaninho,
Scott-Guest and
radumereuta
radumereuta
reviewed
Aug 18, 2023
| String[] args2 = Arrays.copyOfRange(context.getArgs(), 1, context.getArgs().length); | ||
| int result = kserver.run(context.getArgs()[0], args2, new File(context.getWorkingDirectory()), (Map) context.getEnv(), startTime); | ||
| System.exit(result); | ||
| context.exit(result); |
Contributor
There was a problem hiding this comment.
What's the difference between Main.exit and context.texit?
Contributor
Author
There was a problem hiding this comment.
context.exit can be called if you are 100% sure that you are running nailgun. It's probably best to be consistent though; I will fix this.
5 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes K on Java 19 by dealing with the problems relating to nailgun and kserver that were causing it to crash. We do this primarily by updating to a newer version of nailgun with a fix for the issue that it had, but we need to call a different function to exit if Nailgun is active in order to make use of the fix, so there is a slight refactoring to how we call the exit function in K now.
Not tested yet; don't merge.