Allowed attributes for sentence types#3589
Merged
dwightguth merged 8 commits intodevelopfrom Aug 21, 2023
Merged
Conversation
- Remove unused attributes on Array syntax declaration in domains.md
- Remove klabel attributes from rules in regression-new/issue-{1760,999}
- Allow comm attribute on rules. Some Set lemmas in domains.md are using it.
- Allow stream attribute for Productions generated from user defined IO cells
I guess this makes sense as it allows users to make productions that have strictness on them to have priorities.
dwightguth
reviewed
Aug 21, 2023
| final val PREC = Key.builtin("prec", KeyParameter.Required, onlyon[Production]) | ||
| final val PREFER = Key.builtin("prefer", KeyParameter.Forbidden, onlyon[Production]) | ||
| final val PRESERVES_DEFINEDNESS = Key.builtin("preserves-definedness", KeyParameter.Forbidden, onlyon[Rule]) | ||
| final val PRIORITY = Key.builtin("priority", KeyParameter.Required, onlyon2[Production, Rule]) |
Contributor
There was a problem hiding this comment.
Any particular reason this was marked as allowed on productions?
Contributor
Author
There was a problem hiding this comment.
Yeah, there's even a specific commit for this line. There's a k-exercise that has the priority attribute on a configuration declaration cell:
https://github.com/runtimeverification/k/actions/runs/5907674755/job/16025988153#step:7:368
This also made me figure that if strict or seqstrict are being used, then the user might want to control the priority on the rules that are generated there.
Contributor
There was a problem hiding this comment.
Ah I see. Okay. I'm approving this then.
dwightguth
approved these changes
Aug 21, 2023
5 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #3481