Refactor GeneratedTopFormat#3654
Merged
rv-jenkins merged 4 commits intodevelopfrom Sep 22, 2023
Merged
Conversation
6 tasks
radumereuta
force-pushed
the
fixProdHashCode
branch
from
188ffad to
97ac3a0
Compare
Robertorosmaninho
approved these changes
Sep 21, 2023
Collaborator
Robertorosmaninho
left a comment
Robertorosmaninho
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the work and for the tests!
PS. I think that the name of the PR isn't correlated to the final modifications as you took another approach to solve the issue!
5 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3604
Because we didn't check for attribute changes in transformers, we discarded the changes from GeneratedTopFormat.
This moves the code and calls it immediately after the transformation in the same transformer.
It keeps the code in the same place and bypasses the original bug.