Skip loading circularity module for non-circularity proofs#4860
Merged
automergerpr-permission-manager[bot] merged 4 commits intodevelopfrom Oct 1, 2025
Merged
Skip loading circularity module for non-circularity proofs#4860automergerpr-permission-manager[bot] merged 4 commits intodevelopfrom
automergerpr-permission-manager[bot] merged 4 commits intodevelopfrom
Conversation
palinatolmach
approved these changes
Oct 1, 2025
automergerpr-permission-manager
Bot
merged commit 0f400ee
into
develop
67 of 84 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some proofs we're loading are quite large in terms of the configuration and the unevaluated functions in it. They end up taking a long time to load the circularity module dynamically into the backend, even though it won't be used.
This simply skips loading the circularities module for proofs that are not marked as circularities. It should not affect the functionality of the prover at all, and if it does it's likely a bug where we're using the circularities module in a place we shouldn't.
This does mean, that for the pyk prover, circularities must be marked as such (like the sum-spec.k which is marked as such here), otherwise they won't be included automatically as an axiom.