Exclude out/lint from the Foundry.contracts property glob.#1127
Merged
automergerpr-permission-manager[bot] merged 3 commits intomasterfrom Mar 24, 2026
Merged
Exclude out/lint from the Foundry.contracts property glob.#1127automergerpr-permission-manager[bot] merged 3 commits intomasterfrom
out/lint from the Foundry.contracts property glob.#1127automergerpr-permission-manager[bot] merged 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forge lintwrites minimal artifacts that lack the AST section, causing the error below to always trigger on the second run, as the linter runs automatically.In this PR, I'm omitting all the contracts under
out/lintas the artifacts are duplicated and not needed by kontrol.Other Cleanups:
find_enumsfunction definition is moved out of the loop, as originally it was re-created as a new function object on every iteration.str↔Pathround-trip: glob results stay as Path objects throughout.json_path.stemreplacessplit('/')[-1][:-5]: idiomatic and OS-safe.dct.get('nodes', [])infind_enumsto avoidKeyErroron leaf AST nodes.enum_maxonce and reuse instead of callinglen(dct['members'])twice.