Conversation
PetarMax
reviewed
May 31, 2024
PetarMax
reviewed
May 31, 2024
PetarMax
reviewed
May 31, 2024
PetarMax
reviewed
May 31, 2024
src/tests/integration/test-data/show/AssertTest.testFail_expect_revert().expected
Show resolved
Hide resolved
PetarMax
reviewed
May 31, 2024
| @@ -1724,7 +1738,9 @@ module SUMMARY-TEST%ASSERTTEST.TESTFAIL-EXPECT-REVERT():0 | |||
| <k> | |||
Contributor
There was a problem hiding this comment.
From here on, the diff mechanism of GitHub is getting a bit confused because there are many lines that are the same, but then many that are different in between. This is because of the two additional nodes, 13 and 14.
PetarMax
reviewed
May 31, 2024
|
|
||
|
|
||
| rule [BASIC-BLOCK-10-TO-12]: <foundry> | ||
| rule [BASIC-BLOCK-1-TO-15]: <foundry> |
Contributor
There was a problem hiding this comment.
Again, the diff is getting confused because there was a completely expected change in node enumeration, and so the order of the edges of the KCFG is different.
PetarMax
reviewed
May 31, 2024
|
|
||
|
|
||
| rule [BASIC-BLOCK-10-TO-12]: <foundry> | ||
| rule [BASIC-BLOCK-1-TO-15]: <foundry> |
Contributor
There was a problem hiding this comment.
Again, the diff is getting confused because there was a completely expected change in node enumeration, and so the order of the edges of the KCFG is different.
PetarMax
reviewed
May 31, 2024
Contributor
PetarMax
left a comment
PetarMax
left a comment
There was a problem hiding this comment.
This looks good to me. @anvacaru, could you please take one of the CSE expected outputs whose diff has gone AWOL and manually inspect the actual difference to see if there's anything of interest, I suspect there won't be.
There are numerous changes across expected KCFGs in the ids assigned to various nodes; this is because (mostly) setUp functions have more nodes now because of the new cut-point rule to compute the jump destinations, and this gets propagated into the KCFG of the test. This is ok.
Member
|
You can try different diffing mechanisms locally to see if it improves the view. Two options that are useful are
|
Contributor
|
The conflicts currently present are introduced by the merging of #563, which runs contract constructors in CSE-related tests, once the main files have been sorted out the expected outputs will need to be updated. |
Contributor
Author
|
Profiling build stagecse testsintegration tests |
Contributor
Author
|
Integration tests without break on calls |
anvacaru
added a commit
that referenced
this pull request
Jun 4, 2024
Contributor
Author
|
Closing this as I've integrated these changes in 2abe4ef. |
rv-jenkins
added a commit
that referenced
this pull request
Jun 5, 2024
* deps/kevm_release: Set Version 1.0.581
* Set Version: 0.1.297
* Sync Poetry files: kevm-pyk version 1.0.581
* flake.{nix,lock}: update Nix derivations
* deps/kevm_release: Set Version 1.0.582
* Set Version: 0.1.298
* Sync Poetry files: kevm-pyk version 1.0.582
* deps/k_release: sync release file version 7.0.105
* flake.{nix,lock}: update Nix derivations
* deps/kevm_release: Set Version 1.0.583
* Sync Poetry files: kevm-pyk version 1.0.583
* deps/k_release: sync release file version 7.0.106
* flake.{nix,lock}: update Nix derivations
* deps/kevm_release: Set Version 1.0.585
* Set Version: 0.1.299
* Sync Poetry files: kevm-pyk version 1.0.585
* flake.{nix,lock}: update Nix derivations
* deps/kevm_release: Set Version 1.0.586
* Sync Poetry files: kevm-pyk version 1.0.586
* flake.{nix,lock}: update Nix derivations
* deps/kevm_release: Set Version 1.0.587
* Sync Poetry files: kevm-pyk version 1.0.587
* flake.{nix,lock}: update Nix derivations
* from #594: compute jumpdests using the Python custom_step
* update expected output
* from #573: add integration test for symbolic constructor
* test_foundry_prove.py: update label in unit test
* Sync Poetry files: kevm-pyk version 1.0.587
* deps/kevm_release: Set Version 1.0.588
* Sync Poetry files: kevm-pyk version 1.0.588
* deps/k_release: sync release file version 7.0.111
* flake.{nix,lock}: update Nix derivations
* Update kompile expected output
* Set Version: 0.1.300
* Fix local reordering issue in kompile output update
* -m test_identity: update cse expected output
---------
Co-authored-by: devops <devops@runtimeverification.com>
Co-authored-by: Andrei <16517508+anvacaru@users.noreply.github.com>
Co-authored-by: palinatolmach <polina.tolmach@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some experiments here:
EVM.program.loadcustom step. As a way to implement this, the program bytecode is inserted directly into the initial configuration (previously was added using some#binRuntime(ContractName)macro rule generated duringkontrol build.#binRuntimeand#initBytecodemacros, I removed them from the generatedcontracts.k.