Skip to content

Escape kore when used as symbol name #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2025
Merged

Escape kore when used as symbol name #1217

merged 4 commits into from
Oct 15, 2025

Conversation

@jberthold
Copy link
Member

@jberthold jberthold commented Oct 13, 2025 •
edited
Loading

Closes #1216 by using an escaped string with a prefix const_ as the symbol name

@jberthold jberthold marked this pull request as ready for review October 15, 2025 02:37
Robertorosmaninho
Robertorosmaninho requested changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the case where this issue originally happened included in the test suite as a regression test?

@jberthold
Copy link
Member Author

jberthold commented Oct 15, 2025

Can we have the case where this issue originally happened included in the test suite as a regression test?

Good point, will add that.

jberthold
jberthold commented Oct 15, 2025
View reviewed changes
@jberthold jberthold merged commit d4796fb into develop Oct 15, 2025
25 of 28 checks passed
@jberthold jberthold deleted the HOTFIX-escape-symbol-names branch October 15, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Robertorosmaninho Robertorosmaninho Robertorosmaninho approved these changes

@gtrepta gtrepta Awaiting requested review from gtrepta

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jberthold @Robertorosmaninho