Added a feature checklist. #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This list is conservative and many things I have labelled as "Not supported" if I am not sure how this will be in the code.
gtrepta
approved these changes
Apr 7, 2025
Contributor
gtrepta
left a comment
gtrepta
left a comment
There was a problem hiding this comment.
LGTM, I'll defer to @jberthold for confirming how accurate the list is.
jberthold
reviewed
Apr 10, 2025
Co-authored-by: Jost Berthold <jost.berthold@gmail.com>
Collaborator
Author
|
@jberthold I think all your items from your feedback are addressed! Want to sign off and perhaps add automerge if you are happy? |
jberthold
approved these changes
Apr 10, 2025
Member
jberthold
left a comment
jberthold
left a comment
There was a problem hiding this comment.
I guess we have to revisit this table either way, so pre-approving now with change suggestions.
Co-authored-by: Jost Berthold <jost.berthold@gmail.com>
Co-authored-by: Jost Berthold <jost.berthold@gmail.com>
Co-authored-by: Jost Berthold <jost.berthold@gmail.com>
Co-authored-by: Jost Berthold <jost.berthold@gmail.com>
Co-authored-by: Jost Berthold <jost.berthold@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This list is conservative and many things I have labelled as "Not supported" if I am not sure how this will be in the code.