Skip to content

Move Rust setup into Dockerfile#543

Merged
ehildenb merged 4 commits into
masterfrom
rust-docker
Apr 30, 2025
Merged

Move Rust setup into Dockerfile#543
ehildenb merged 4 commits into
masterfrom
rust-docker

Conversation

@ehildenb
Copy link
Copy Markdown
Member

As part of #542, we noticed that the Dockerfile does not install Rust, and we need it for integration tests run there. This PR makes sure rustc and cargo are available to run in the docker image for CI:

  • The rustup install step is moved to inside the docker image.
  • The steps for building KMir in the tests "Integration with stable-mir-json" are all moved to being in the docker image.

@ehildenb ehildenb self-assigned this Apr 30, 2025
Copy link
Copy Markdown
Collaborator

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ehildenb
Copy link
Copy Markdown
Member Author

yaaaay!!!

@ehildenb ehildenb marked this pull request as ready for review April 30, 2025 01:26
@ehildenb ehildenb merged commit 1f24db8 into master Apr 30, 2025
6 checks passed
@ehildenb ehildenb deleted the rust-docker branch April 30, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants