chore: update feature/p-token branch with master changes
#774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for `binOpOffset` - `binOpOffset` is applied to a `PtrLocal` but must come from a `Range` of some kind (e.g. `[u8; 2]`, `&[u8]`) in which case the offset is applied to a pointer to the element e.g. `*const u8`; - Both `Reference` and `PtrLocal` has the same `Metadata` that tracks and offset; - In order to ensure that pointers are not out of range when the offset is applied, `Metadata` has an `OriginSize` field for `PtrLocal` and `Reference` for the necessary bounds checking in the external `Range`; - After an offset is applied to a `PtrLocal` it can be turned back into a `Reference`, which essentially is an index into the `Range` but it does not return the element type but the `Range` type (with smaller bounds); - The bulk of the change is in `#traverseProjection` that now needs to account for an offset when a `projectionDeref` occurs; - When a non-zero offset is encountered a `ProjectionElem::PointerOffset` is appended to the place projections, later this will be turned into a `CtxPointerOffset` when the contexts are being processed; - `CtxPointerOffset` is essentially the same as a subslice as we must have a `Range` to be offsetting through Test cases for read and write are added --------- Co-authored-by: Jost Berthold <jost.berthold@gmail.com>
Stevengre
requested review from
JuanCoRo,
dkcumming,
jberthold and
tothtamas28
jberthold
approved these changes
Oct 27, 2025
Member
jberthold
left a comment
jberthold
left a comment
There was a problem hiding this comment.
Please use the Create a merge commit option to merge it
(we all keep forgetting it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.