assert_inhabited intrinsic support#851
Merged
automergerpr-permission-manager[bot] merged 4 commits intoNov 18, 2025
Merged
Conversation
jberthold
approved these changes
Nov 18, 2025
Collaborator
jberthold
left a comment
jberthold
left a comment
There was a problem hiding this comment.
LGTM.
Too bad the iter() invocation still does not go through....
automergerpr-permission-manager
Bot
merged commit 57345df
into
master
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assert_inhabited intrinsic will (possibly) panic if a type in uninhabited (cannot be instantiated). E.g.
Despite being an
assert, panicking is not guaranteed and is dependent on the target and code generation - it is sound to perform a NO OP. Since calling the intrinsic comes from aTerminatorKind::Call, there must be aBasicBlockto go to after the call. However we observe that forassert_inhabited<!>()the execution continues tonoBasicBlockIdx(which would get stuck). The semantics looks for this case and converts to#AssertInhabitedFailure, and otherwise performs aNO OP.