Added transmute cast for Range of T into Range of MaybeUninit<T>
#913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterating through a collection, the elements of the the range of the collection are transmuted from
Ttostd::mem::MaybeUninit<T>. Previously this thunked (as can be seen in therun-smir-randomtests), but the new rules allow for element-wise transmutation specifically for the case seen in iterators.Not added in this PR is the ability to read from these which is a more complicated process of interpretting a
PtrToPtrconversion on a transparent wrapper types which do not currently support non-zero union field access. This is a problem for this as field1ofMaybeUninitcorresponds to the case that is initialised. See #914