fix: type of offset for applyBinOp(binOpOffset, ...)#936
Merged
automergerpr-permission-manager[bot] merged 2 commits intomasterfrom Feb 9, 2026
Merged
fix: type of offset for applyBinOp(binOpOffset, ...)#936automergerpr-permission-manager[bot] merged 2 commits intomasterfrom
automergerpr-permission-manager[bot] merged 2 commits intomasterfrom
Conversation
…sed to compute both offset and get_unchecked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of the offset that can reach this rule can be unsigned or signed, depending on the method used in the source code (offset, get_unchecked). This PR makes that change, and updates the relevant tests.