Skip to content

Conversation

@ChristianoBraga
Copy link

@ChristianoBraga ChristianoBraga commented Nov 8, 2022

  • Remove uplc-genvironment-instance.uplc from kplc-files in the Makefile. Add it to tests/spec/simple. Each verificable UPLC code must have verification dir, verification.md and possibly uplc-genvironment-instance.md file.`
  • Add .expected files to tests/textual/benchmark-validation-examples.
  • Update tests/failing by removing filenames in tests/textual/benchmark-validation-examples.

@ChristianoBraga ChristianoBraga marked this pull request as draft November 8, 2022 17:52
@ChristianoBraga ChristianoBraga force-pushed the instance-relocation branch 3 times, most recently from 180db28 to 7c8c053 Compare November 8, 2022 18:18
  Makefile. Add it to `tests/spec/simple`. Each verificable UPLC code
  must have `verification` dir, `verification.md` and possibly
  `uplc-genvironment-instance.md` file.`
@ChristianoBraga ChristianoBraga marked this pull request as ready for review November 8, 2022 18:28
Christiano Braga and others added 3 commits November 9, 2022 17:18
Co-authored-by: gtrepta <50716988+gtrepta@users.noreply.github.com>
Co-authored-by: gtrepta <50716988+gtrepta@users.noreply.github.com>

test-pr:
name: 'Bulid and test KPlutus'
name: 'Build and test KPlutus'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should do this change elsewhere, or I can adjust the check name name. But this affects the required status checks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can leave this change for my PR: #359

Christiano Braga added 2 commits November 9, 2022 18:06
  Makefile. Add it to `tests/spec/simple`. Each verificable UPLC code
  must have `verification` dir, `verification.md` and possibly
  `uplc-genvironment-instance.md` file.`
@gtrepta gtrepta self-requested a review November 9, 2022 21:28
@rv-jenkins rv-jenkins merged commit c80b66f into master Nov 9, 2022
@rv-jenkins rv-jenkins deleted the instance-relocation branch November 9, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants