This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Added execution time to APRSummary#908
Merged
rv-jenkins merged 6 commits intomasterfrom Feb 22, 2024
Merged
Conversation
| f' terminal: {self.terminal}', | ||
| f' refuted: {self.refuted}', | ||
| f' bounded: {self.bounded}', | ||
| f' execution time: {round(self.exec_time,2)}', |
Contributor
There was a problem hiding this comment.
Suggested change
| f' execution time: {round(self.exec_time,2)}', | |
| f' execution time: {round(self.exec_time, 2)}', |
Contributor
There was a problem hiding this comment.
If we're printing this information, shall we add s (for seconds) to the line? (or ms, depending on what we're measuring the time it)
I.e., something like
f' execution time: {round(self.exec_time, 2)}s',
Contributor
Author
There was a problem hiding this comment.
You are right! It's in s, but I am wondering if it wouldn't make sense to present the result in minutes.
Contributor
Author
There was a problem hiding this comment.
@palinatolmach what do you think of displaying it as execution time: 0h 1m 33s?
Contributor
There was a problem hiding this comment.
Thanks for the update!
palinatolmach
approved these changes
Feb 22, 2024
virgil-serbanuta
pushed a commit
that referenced
this pull request
Feb 23, 2024
Needed to implement [Issue 389](runtimeverification/kontrol#389) in Kontrol. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
Needed to implement [Issue 389](runtimeverification/kontrol#389) in Kontrol. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
Needed to implement [Issue 389](runtimeverification/kontrol#389) in Kontrol. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
Needed to implement [Issue 389](runtimeverification/kontrol#389) in Kontrol. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
Needed to implement [Issue 389](runtimeverification/kontrol#389) in Kontrol. --------- Co-authored-by: devops <devops@runtimeverification.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to implement Issue 389 in Kontrol.