This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Move kcfg commit logic to KCFG class#909
Merged
rv-jenkins merged 5 commits intomasterfrom Feb 22, 2024
Merged
Conversation
nwatson22
requested review from
ehildenb and
tothtamas28
and removed request for
ehildenb
ehildenb
reviewed
Feb 22, 2024
ehildenb
approved these changes
Feb 22, 2024
virgil-serbanuta
pushed a commit
that referenced
this pull request
Feb 23, 2024
- `KCFGExplore.extend_kcfg()` replaced by `KCFG.extend()` - Logging of `ExtendResult`s moved earlier to when they are created (before, they were logged when applied, but this is no longer possible with application logic (`extend()`) living in `KCFG`. - `KCFGExplore.extend()` removed and its logic moved up into `advance_pending_node()` --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
- `KCFGExplore.extend_kcfg()` replaced by `KCFG.extend()` - Logging of `ExtendResult`s moved earlier to when they are created (before, they were logged when applied, but this is no longer possible with application logic (`extend()`) living in `KCFG`. - `KCFGExplore.extend()` removed and its logic moved up into `advance_pending_node()` --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
- `KCFGExplore.extend_kcfg()` replaced by `KCFG.extend()` - Logging of `ExtendResult`s moved earlier to when they are created (before, they were logged when applied, but this is no longer possible with application logic (`extend()`) living in `KCFG`. - `KCFGExplore.extend()` removed and its logic moved up into `advance_pending_node()` --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
- `KCFGExplore.extend_kcfg()` replaced by `KCFG.extend()` - Logging of `ExtendResult`s moved earlier to when they are created (before, they were logged when applied, but this is no longer possible with application logic (`extend()`) living in `KCFG`. - `KCFGExplore.extend()` removed and its logic moved up into `advance_pending_node()` --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
- `KCFGExplore.extend_kcfg()` replaced by `KCFG.extend()` - Logging of `ExtendResult`s moved earlier to when they are created (before, they were logged when applied, but this is no longer possible with application logic (`extend()`) living in `KCFG`. - `KCFGExplore.extend()` removed and its logic moved up into `advance_pending_node()` --------- Co-authored-by: devops <devops@runtimeverification.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KCFGExplore.extend_kcfg()replaced byKCFG.extend()ExtendResults moved earlier to when they are created (before, they were logged when applied, but this is no longer possible with application logic (extend()) living inKCFG.KCFGExplore.extend()removed and its logic moved up intoadvance_pending_node()