Add division operations for RISC-V semantics#146
Merged
automergerpr-permission-manager[bot] merged 8 commits intomasterfrom Jun 20, 2025
Merged
Add division operations for RISC-V semantics#146automergerpr-permission-manager[bot] merged 8 commits intomasterfrom
automergerpr-permission-manager[bot] merged 8 commits intomasterfrom
Conversation
Implement signed (`/Word`) and unsigned (`/uWord`) division rules in the RISC-V semantics. Update the handling of special cases for division by zero and signed overflow. Refactor test functions to include comprehensive test cases for both division operations, ensuring compliance with RISC-V specifications. - Added rules for `DIV` and `DIVU` instructions in `riscv.md`. - Updated syntax definitions in `word.md` for division operations. - Introduced new test cases for division in `test_functions.py` to validate expected behavior.
tothtamas28
reviewed
Jun 20, 2025
Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
- Extracted expected result calculations for signed and unsigned division into separate functions: `div_expected` and `divu_expected`. - Updated test functions to use the new expected result functions, improving code clarity and maintainability. - Ensured compliance with RISC-V specifications for division operations.
tothtamas28
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement signed (
/Word) and unsigned (/uWord) division rules in the RISC-V semantics. Update the handling of special cases for division by zero and signed overflow. Refactor test functions to include comprehensive test cases for both division operations, ensuring compliance with RISC-V specifications.DIVandDIVUinstructions inriscv.md.word.mdfor division operations.test_functions.pyto validate expected behavior.