fix(spl): modify tests for process_withdraw_excess_lamports with InvalidInstruction
#146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkcumming
reviewed
Jan 8, 2026
Collaborator
There was a problem hiding this comment.
I don't understand this, if we change the post-condition from what there is for p-token we are going to break our definition of equivalence. What is the goal with this change? EDIT: Sorry I wasn't fully paying attention when I reviewed this, I see what you mean, let me take a closer look though.
dkcumming
reviewed
Jan 9, 2026
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
Really I think this can be reduced to one harness that fails in all cases right?
fn test_process_withdraw_excess_lamports_multisig(
program_id: &Pubkey,
accounts: &[AccountInfo; 3],
instruction_data: &[u8; 1],
) -> ProgramResult {
//-Process Instruction-----------------------------------------------------
let result = Processor::process(program_id, accounts, instruction_data_with_discriminator);
assert_eq!(result, Err(TokenError::InvalidInstruction.into()));
result
}
dkcumming
approved these changes
Jan 9, 2026
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
Awesome, the performance gain on these proofs with this change should be massive! ;)
dkcumming
pushed a commit
that referenced
this pull request
Jan 21, 2026
…alidInstruction` (#146) `process_withdraw_excess_lamports` is missed in spl-token and implemented in token-2022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_withdraw_excess_lamportsis missed in spl-token and implemented in token-2022.