Added mutability to PtrType and RefType TypeInfo#127
Merged
automergerpr-permission-manager[bot] merged 1 commit intomasterfrom Feb 28, 2026
Merged
Added mutability to PtrType and RefType TypeInfo#127automergerpr-permission-manager[bot] merged 1 commit intomasterfrom
PtrType and RefType TypeInfo#127automergerpr-permission-manager[bot] merged 1 commit intomasterfrom
Conversation
mariaKt
approved these changes
Feb 27, 2026
cds-amal
approved these changes
Feb 27, 2026
Collaborator
cds-amal
left a comment
cds-amal
left a comment
There was a problem hiding this comment.
Makes sense! The mk_graph TypeKind::Ptr/Ref variants now carry mutability, but nothing in the graph rendering reads it yet. Not a blocker (the data is there for when someone needs it), but worth tracking as a follow-up.
I created issue #128 to track it.
Collaborator
Author
Actually the graph rendering already was _display_ing the information because the 
|
cds-amal
added a commit
to cds-rs/stable-mir-json
that referenced
this pull request
Mar 1, 2026
…ntimeverification#124, runtimeverification#126, runtimeverification#127 Several merged PRs were missing from the changelog or lacked PR links: - runtimeverification#127: mutability field on PtrType/RefType in TypeMetadata - runtimeverification#124: ADR-001 (index-first graph architecture) - runtimeverification#121: existing entries for 3-phase pipeline, AllocMap coherence, and dead fixup removal now link to the PR - runtimeverification#126: existing entries for UI test runner rewrite and provenance resolution fixes now link to the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error was seen with
PtrToPtrcasts in mir-semantics when there is an array of arrays being cast to change mutability. The current model incorrectly assumes it wants to point to an interior element, but this case needs to be distinguished from the case that is purely changing mutability. Therefore the mutability of the pointer needs to be accessible in theTypeInfo