Fix/mixin injection return#5
Merged
Merged
Conversation
HEAD injection on a single-IRETURN method NPEs in Mixin's legacy injector because there is no instruction *before* the return for it to anchor to. RETURN targets the IRETURN instruction directly — always present, always safe.
MinecraftServer declares getOpPermissionLevel() as abstract — no bytecode body, so Mixin cannot inject into it (NPE on IRETURN lookup). The concrete implementation lives in IntegratedServer, which is the actual singleplayer server class. Targeting IntegratedServer resolves the injection correctly.
IntegratedServer is client-only; net.minecraft.server.integrated is not on the main source set compile classpath, causing build failure. Moving DLMixin -> DLServerMixin into src/client and registering it in datalib.client.mixins.json resolves the compile error.
- Label: datalib$label() was prepending the permission_level translation key itself, but CyclingButtonWidget already does that via its name param, causing 'İzin Seviyesi: İzin Seviyesi: ...' duplication. Now returns only the level description text. - Active flag: DLLanSettings.active was only set when the user clicked the button. If the screen was opened and closed without interaction, active stayed false and DLServerMixin skipped the override entirely. Now set active=true in init() so the configured level is always applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.