fix(codegen): eliminate dead optimizer L3 arena allocation#25
Merged
Conversation
The arena-elimination regex in _patch_shared_buffers only matched pi_*_malloc (L2) but not cl_ram_malloc (L3). When all optimizer I/O buffers are shared with the training network, the L3 arena has no remaining pointer-arithmetic references and should be removed — but the regex silently failed to match the cl_ram_malloc call, leaving a dead allocation that wastes external RAM. Extend the pattern to match both pi_*_malloc and cl_ram_malloc so the dead-code check works uniformly across all memory levels. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
runwangdl
force-pushed
the
fix/optimizer-l3-arena-elimination
branch
from
5554fe6 to
56000b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_patch_shared_buffersonly matchedpi_*_malloc(L2) but missedcl_ram_malloc(L3)cl_ram_mallocthat wastes external RAM(?:pi_\w+_malloc|cl_ram_malloc)so dead-code elimination works for all memory levelsImpact
For SimpleMLP: saves 4,736 bytes of L3 (external RAM). For larger models the savings scale with the optimizer arena size.
Test plan
cl_ram_mallocforMEMORYARENA_L3is absent fromOptimizerNetwork.cdeeployTrainingRunner_siracusa.py -t Tests/Models/Training/SimpleMLP/simplemlp_train— loss values match reference