feat: add meal balance breakdown component#18
Merged
Erick2280 merged 4 commits intorusbeapp:developfrom Jan 3, 2025
Merged
Conversation
Erick2280
reviewed
Jan 3, 2025
Comment on lines
+16
to
+21
| @Input() mealType: MealType = MealType.Lunch; | ||
| @Input() calculationType: CalculationType = 'equivalence'; | ||
| @Input() mealValue = BrlCurrency.fromNumber(0); | ||
| @Input() mealCount = 0; | ||
| @Input() totalCost = BrlCurrency.fromNumber(0); | ||
| @Input() balanceLeft = BrlCurrency.fromNumber(0); |
Erick2280
reviewed
Jan 3, 2025
| balanceLeft: BrlCurrency; | ||
| } | ||
|
|
||
| export type CalculationType = 'equivalence' | 'details'; |
Erick2280
reviewed
Jan 3, 2025
Comment on lines
+24
to
+28
| @Input() calculationType: CalculationType = 'equivalence'; | ||
| @Input() mealPrincingProfile: MealPricingProfile = MEAL_PRICING_PROFILES[1]; | ||
| @Input() numberOfDinners = 0; | ||
| @Input() numberOfLunches = 0; | ||
|
|
Member
There was a problem hiding this comment.
Use new Angular input() syntax
Erick2280
reviewed
Jan 3, 2025
Co-authored-by: Erick Almeida <Erick2280@users.noreply.github.com>
Erick2280
reviewed
Jan 3, 2025
| @@ -0,0 +1,31 @@ | |||
| <div | |||
| class="flex justify-between" | |||
Member
There was a problem hiding this comment.
Set flex direction for clarity
Erick2280
reviewed
Jan 3, 2025
| </div> | ||
| <div | ||
| *ngIf="calculationType === 'details'" | ||
| class="flex items-center justify-between pr-5" |
Member
There was a problem hiding this comment.
Set flex direction for clarity
Erick2280
reviewed
Jan 3, 2025
| imports: [MealBalanceTableComponent, NgFor, NgIf, SlicePipe], | ||
| templateUrl: './meal-balance-breakdown.component.html', | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| host: { class: 'flex flex-col gap-5' }, |
Member
There was a problem hiding this comment.
Set flex direction for clarity
Collaborator
Author
There was a problem hiding this comment.
Flex direction was already set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.