Conversation
|
Visit the preview URL for this PR (updated for commit 225a023): https://rusbeplatform--pr21-feat-add-top-up-page-12t59o5d.web.app (expires Thu, 13 Mar 2025 02:31:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7ac055a794bf319cb7386a70c5f00a959ddb7b14 |
| subtitle = input(''); | ||
| iconName = input(''); | ||
| badgeText = input(''); |
There was a problem hiding this comment.
nit: Maybe use input.required() here? (or string | undefined to be more clear if it's not)
There was a problem hiding this comment.
Updated, left only badgeText being optional.
| host: { class: 'grouping-card' }, | ||
| }) | ||
| export class CardGroupComponent { | ||
| title = input(''); |
There was a problem hiding this comment.
nit: Maybe use input.required() here?
| import { provideNgxMask } from 'ngx-mask'; | ||
|
|
||
| @Component({ | ||
| selector: 'rusbe-jumbo-text-input', | ||
| imports: [NgxMaskDirective, FormsModule], | ||
| imports: [FormsModule], |
There was a problem hiding this comment.
Please don't remove this import 😭 I fixed it in a later commit
| Você tem R$ <strong>{{ currentBalance().value }} </strong> de saldo. Após a | ||
| transação, você ficará com R$ <strong> {{ newBalance() }}</strong |
There was a problem hiding this comment.
This is showing NaN when currency input is empty.
There was a problem hiding this comment.
Add check for NaN on computed value.
| const cpfNumber = this.cpf(); | ||
| if (!cpfNumber) return ''; | ||
| return cpfNumber.replace(/(\d{3})(\d{3})(\d{3})(\d{2})/, '$1.$2.$3-$4'); |
There was a problem hiding this comment.
A General Goods identifier may not be a CPF (🥲), so check if it has 11 characters before formatting
There was a problem hiding this comment.
Added early return in case it's not 11 characters.
| [customAction]="goToPreviousStage.bind(this)" | ||
| [type]="headerType()" | ||
| > | ||
| ADICIONAR CRÉDITOS |
There was a problem hiding this comment.
nit: Header component automatically transforms text to be uppercase
| [TopUpError.Generic]: | ||
| 'Ocorreu um erro desconhecido. Por favor, tente novamente.', | ||
| }; | ||
| readonly FIFHTEEEN_MINUTES = 15 * 60 * 1000; |
There was a problem hiding this comment.
| readonly FIFHTEEEN_MINUTES = 15 * 60 * 1000; | |
| readonly FIFTEEN_MINUTES = 15 * 60 * 1000; |
There was a problem hiding this comment.
Fixed locally updating other occurences.
Co-authored-by: Erick Almeida <Erick2280@users.noreply.github.com>
Co-authored-by: Erick Almeida <Erick2280@users.noreply.github.com>
Guilhermeasper
force-pushed
the
feat/add-top-up-page
branch
from
82d9cad to
0dd088c
Compare
2 participants
No description provided.