Skip to content

model uses crate::ScriptPubkey but it is not strongly typed #369

@tcharding

Description

@tcharding

model types are supposed to be strongly typed using types from rust-bitcoin however we are using the crate::ScritpPubkey type.

Found because @benthecarman wants to make the conversion getters public in #368

E.g. model::blockchain::SpendActivity

If I remember correctly when we added this I was lazy and did not know exactly how to convert into a model type (eg should we keep the asm field or use ScriptBuf::to_asm_string()).

Think through this properly and probably add a model type and implement into_model on crate::ScriptPubkey.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions