Skip to content

serde-deny-unknown-fields pointless in model #373

@tcharding

Description

@tcharding

The deny unknown fields attribute was added so that in testing we catch mistakes in what Core returns and what we expect to get. In model we derive serde traits so that users of the lib can persist the types if they want to, the model types are never used directly with Core. It does not make sense to have the deny unknown fields attribute in model.

100% my mistake for not noticing this during review when we added the attribute, and then again later when we feature gated the attribute.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions