Skip to content

bitreq notes #402

@TheBlueMatt

Description

@TheBlueMatt

Looking through bitreq, a few notes:

  • it looks like the punycode feature isn't fully implemented (I only see punycode::encode called, never decode). IMO we can just drop it, but maybe someone would complain.
  • dunno why src/main.rs is there :)
  • there's an implementation of url encoding in src/http_url.rs, but then src/request.rs relies on the urlencoding crate as a dep, we should probably drop the dependency.
  • the tokio dep looks like it has some unused features
  • can we get some of the nice top-level request functions for async requests?
  • it looks like wasm.rs isn't hooked up anywhere (its not in lib.rs so presumably its not actually callable)? Also, the API to C/JS really shouldn't have the implicit "last request" but rather there needs to be a pointer returned, accessors and a free method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions