Implement verifychain method and test #155
Conversation
removed the unnecessary lines of the rust docs, leaving just a single line, as you suggested.... |
|
While reviewing this I saw that we have the integration test for FTR I'm as fallible as the next bloke, if you see mistakes please clean em up - its super appreciated. This repo is even more necessary to keep clean than most because its so big, boring, boilerplate. In general you can either do them as separate PRs, or if the PR you are working is going to include the mistake in the diff just put the fix as a separate patch at the front of the PR i.e., do it first in a separate patch (commit). |
|
Thanks man, you are killing it! |
Thank you.... I am learning from you... |
ae286f1d70bcedcf4a3486764e00d518be09893f Implement verifychain method and test (GideonBature) Pull request description: This is based on PR rust-bitcoin/corepc#116 on implementing one method at a time for easier review: This is the third method implementation: `verifychain` which returns a (bool type). Once this is approved, I’ll proceed with the next one. ACKs for top commit: tcharding: ACK ae286f1d70bcedcf4a3486764e00d518be09893f Tree-SHA512: 9992984539ead8a63b394b431df0b52cf99d552d17c3c4930aa406660e1b51b5e43fc07e5bfeda1f7c9c0234278d212d42e2f893b97a7de1e208199bc8012aca
2 participants
The JSON-RPC method
verifychainreturns a standard type (bool). We would like to test this in case a later version of Core changes this behaviour.This PR adds a client function that errors if the return value is anything other than
bool, along with an integration test that calls this function.Ref: #116