Implement setban method and test #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
approved these changes
May 24, 2025
|
Quick one! Nice. Stick at it man. |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
7579c309bfdb0a3f93ee59d9054de565a50f7271 Implement setban method and test (GideonBature) Pull request description: Going by the conversations with tcharding for PR [#116 ](rust-bitcoin/corepc#116) on implementing one method at a time for easier review: This is another method under network section, setban which is a specific type that returns a (json null). Once this is approved, I’ll proceed with the next one. ACKs for top commit: tcharding: ACK 7579c309bfdb0a3f93ee59d9054de565a50f7271 Tree-SHA512: abe19120103d1c6985e24d0bb6806f7042f7ab980b28ae14d2e15a84afe751a60168f146f4d8542d885628502d759748df4b885a9e4053c2c134ddbe69723176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON-RPC method
setbanreturns a null. We would like to test this in case a later version of Core changes this behaviour.This PR adds a client function that errors if the return value is anything other than
null, along with an integration test that calls this function.Ref: #116