Skip to content

Conversation

GideonBature
Copy link
Contributor

The JSON-RPC method getconnectioncount does return a numeric. We want to test this to catch any changes in behavior in future Core versions.

This PR adds a client function that errors if the return value is anything other than numeric, along with an integration test that calls this function.

Ref: #116

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2408e45

@tcharding
Copy link
Member

Hey mate, from now on, to make reviewing the re-export change easier can you just throw the re-export in at the end of the list on its own line. Then in a separate commit run just fmt. That way we can be sure we don't accidentally introduce any mistakes. Holla if you don't understand what I mean.

@tcharding
Copy link
Member

Woops, I rescind my ack. We need to update the tables Returns column s/returns numeric/version/.

@GideonBature
Copy link
Contributor Author

Hey mate, from now on, to make reviewing the re-export change easier can you just throw the re-export in at the end of the list on its own line. Then in a separate commit run just fmt. That way we can be sure we don't accidentally introduce any mistakes. Holla if you don't understand what I mean.

I understand, instead of inserting it manually in the midst of existing re-exports. I will do just that... Thank you.

@GideonBature
Copy link
Contributor Author

Woops, I rescind my ack. We need to update the tables Returns column s/returns numeric/version/.

I thought about this, since those returning the std types now have a type that wraps them, whether to use just version or mixture of version and the std type.

@tcharding
Copy link
Member

version please.

@GideonBature
Copy link
Contributor Author

Alright, noted. Will update all the existing ones.

@tcharding tcharding merged commit aaffcaa into rust-bitcoin:master May 31, 2025
29 checks passed
@GideonBature GideonBature deleted the getconnectioncount branch May 31, 2025 08:09
blaze-smith470pm added a commit to blaze-smith470pm/corepc that referenced this pull request Sep 26, 2025
…d test

2408e45a7154e487e08ee24c591e4b23729d1a5d Implement getconnectioncount method and test (GideonBature)

Pull request description:

  The JSON-RPC method `getconnectioncount` does return a numeric. We want to test this to catch any changes in behavior in future Core versions.

  This PR adds a client function that errors if the return value is anything other than `numeric`, along with an integration test that calls this function.

  Ref: [#116](rust-bitcoin/corepc#116)

ACKs for top commit:
  tcharding:
    ACK 2408e45a7154e487e08ee24c591e4b23729d1a5d

Tree-SHA512: 8fadbbe57fe567daebe150cf76cce96d0693ee1763bd8bbfafe4b736751da8dc42b2681aeccf7eb8fbc03083a2ecb131ee59ffc24608ea20ec3693b944477147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants