-
Notifications
You must be signed in to change notification settings - Fork 39
Implement getconnectioncount method and test #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement getconnectioncount method and test #212
Conversation
e7dd946
to
cd65058
Compare
cd65058
to
2408e45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2408e45
Hey mate, from now on, to make reviewing the re-export change easier can you just throw the re-export in at the end of the list on its own line. Then in a separate commit run |
Woops, I rescind my ack. We need to update the tables |
I understand, instead of inserting it manually in the midst of existing re-exports. I will do just that... Thank you. |
I thought about this, since those returning the std types now have a type that wraps them, whether to use just |
|
Alright, noted. Will update all the existing ones. |
…d test 2408e45a7154e487e08ee24c591e4b23729d1a5d Implement getconnectioncount method and test (GideonBature) Pull request description: The JSON-RPC method `getconnectioncount` does return a numeric. We want to test this to catch any changes in behavior in future Core versions. This PR adds a client function that errors if the return value is anything other than `numeric`, along with an integration test that calls this function. Ref: [#116](rust-bitcoin/corepc#116) ACKs for top commit: tcharding: ACK 2408e45a7154e487e08ee24c591e4b23729d1a5d Tree-SHA512: 8fadbbe57fe567daebe150cf76cce96d0693ee1763bd8bbfafe4b736751da8dc42b2681aeccf7eb8fbc03083a2ecb131ee59ffc24608ea20ec3693b944477147
The JSON-RPC method
getconnectioncount
does return a numeric. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than
numeric
, along with an integration test that calls this function.Ref: #116