Implement ping method and test #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
approved these changes
Jun 1, 2025
|
Grinding them out! Well done, keep at it. |
|
Thank you!!! |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
8b1f5782afd21aba158fe1b23103997067e414c5 Implement ping method and test (GideonBature) Pull request description: The JSON-RPC method `ping` does return null. We want to test this to catch any changes in behavior in future Core versions. This PR adds a client function that errors if the return value is anything other than `null`, along with an integration test that calls this function. Ref: [#116](rust-bitcoin/corepc#116) ACKs for top commit: tcharding: ACK 8b1f5782afd21aba158fe1b23103997067e414c5 Tree-SHA512: c2626a22f96179e22154a8830a53d6b2568c959515244445dc6481572bde8f45ea9eec16f82bafa19ad8c31814c49d6ccf2e3d0a1d279191548e420d3d15d55d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON-RPC method
pingdoes return null. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than
null, along with an integration test that calls this function.Ref: #116