Add support for run-bitcoind.sh start all #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On more than one occasion I have tried to start all nodes by passing `run all` or `start all` instead of just `all`. Handle this the same as passing `all` as the argument to the script.
tcharding
approved these changes
Aug 1, 2025
Member
|
Nice, this bothered me a bunch too. |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
25c8bf6f8ad7d1214db5b90d33d0b20504afe8f2 Add support for run-bitcoind.sh start all (Jamil Lambert, PhD)
Pull request description:
On more than one occasion I have tried to start all nodes by passing `run all` or `start all` instead of just `all`.
Handle this the same as passing `all` as the argument to the script.
ACKs for top commit:
tcharding:
ACK 25c8bf6f8ad7d1214db5b90d33d0b20504afe8f2
Tree-SHA512: 9ab58f51e082a0db6c09b5131d2867d2e08e45901d8cc74a559104a6d5d5c92435f905bcfff8a4515405073aca83713c5ddba821a6a5ad7872ec44e26c47875f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On more than one occasion I have tried to start all nodes by passing
run allorstart allinstead of justall.Handle this the same as passing
allas the argument to the script.