Address all TODO in v29 #324
Merged
+91
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v29 supports multipath descriptors when calling `deriveaddresses`. Add a new struct, model and client function for DeriveAddressesMultipath. Update the test for v29 to check a multipath descriptor.
tcharding
approved these changes
Aug 5, 2025
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
045809995fe287851c6af8685e347c7b19a27532 Add deriveaddresses multipath (Jamil Lambert, PhD)
Pull request description:
One TODO in v29 for `deriveaddresses`
The change is that it now supports multipath descriptors when calling `deriveaddresses`.
Add a new struct, model and client function for DeriveAddressesMultipath.
Update the test for v29 to check a multipath descriptor.
ACKs for top commit:
tcharding:
ACK 045809995fe287851c6af8685e347c7b19a27532
Tree-SHA512: 28656e14eede5b1e4d6af6b4256a07031d67177bff8a2c8498a6122854a091066ee7bfd3d6943437c548e1c3b429335a1c0d4e802277d12981eab7086f5596a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One TODO in v29 for
deriveaddressesThe change is that it now supports multipath descriptors when calling
deriveaddresses.Add a new struct, model and client function for DeriveAddressesMultipath.
Update the test for v29 to check a multipath descriptor.