Test and update listsinceblock and listtransactions
#347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamillambert
force-pushed
the
0828-listsinceblock
branch
from
f84d625 to
b6eda85
Compare
jamillambert
changed the title
listsinceblocklistsinceblock and listtransactions
jamillambert
force-pushed
the
0828-listsinceblock
branch
from
b6eda85 to
b859315
Compare
Move wallet.rs to ./wallet/mod.rs Split out the into_model() into an into module. Code move only.
The RPC was implemented for v17 and untested. Some fields are optional or undocumented. Fix the struct for v17. Update the struct, model, into_model, and error for changes in v20, v23, v24 and v28. Add a test and update the types tables.
Both RPCs return the same shape sub type. Including the changes in versions between 17 and 29. ListSinceBlockTransaction has all the changes implemented up to v29. Use ListSinceBlockTransaction for both RPCs including the error and into functions. Rename it to TransactionItem to be more general. Remove ListTransactionsItem and associated error and into functions.
The RPC was implemented for v17 and untested. The struct now uses the fixed `TransactionItem` struct and associated error and into functions. Update all the version types to use the fixed `TransactionItem`. Add a test and update the types tables.
Reordering of the reexports only
jamillambert
force-pushed
the
0828-listsinceblock
branch
from
b859315 to
a07b91c
Compare
Collaborator
Author
|
Rebased |
tcharding
reviewed
Sep 4, 2025
Comment on lines
-24
to
+25
| // - ListSinceBlockTransaction | ||
| // - ListTransactionsItem | ||
| // - TransactionItem | ||
| // - TransactionItem |
tcharding
approved these changes
Sep 4, 2025
Member
|
GitHub seems to be glitching out github-merge 347 ✘ 1
Warning: unable to retrieve pull information from github: HTTP Error 403: rate limit exceeded
Detailed error: b'{"message":"API rate limit exceeded for 106.69.114.232. (But here\'s the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}\n'Merging manually. We can fix the docs typo thing later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both RPCs were implemented for v17 and untested, and the structs are not exactly what is returned by the RPC in v17 since some of the fields are optional or undocumented.
wallet.rsto./wallet/mod.rsinto_model()into anintomodule.listsinceblock.listsinceblockstruct for v17.listtransactionshas the exact same sub type, including the changes to the returned fields updated in the above patch.ListSinceBlockTransactiontoTransactionItemand the associated error. Use this forListTransactions.ListTransactions.listtransactions.