Remove BlockTemplateTransaction from v29 #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an empty file left over from a previous commit's code reorginazation. Remove the empty file.
Why is it even there? it's not even an RPC, it's the `transactions` field of GetBlockTemplate which hasn't changed since v17. Remove it.
jamillambert
force-pushed
the
0909-GetBlockTemplate
branch
from
1c64026 to
e85b1bf
Compare
tcharding
approved these changes
Sep 9, 2025
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
e85b1bf6d8521871d80dc5551d208b7d9f70f985 Remove BlockTemplateTransaction from v29 (Jamil Lambert, PhD)
da52d8f014503a072e9199d154caa87cdfdf1dd8 Remove empty file (Jamil Lambert, PhD)
Pull request description:
Why is it even there? it's not even an RPC, it's the `transactions` field of `GetBlockTemplate` which hasn't changed since v17.
Remove it.
Also remove an empty file left over from a previous change.
ACKs for top commit:
tcharding:
ACK e85b1bf6d8521871d80dc5551d208b7d9f70f985
Tree-SHA512: dd574a99ca5488d75a42dc83920446188668a47d7ab88f830f8b655cbe190c70413558274a95c27d53e95057029990e7b1c1c89f40cb0f371c5bccabd3bb1efa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is it even there? it's not even an RPC, it's the
transactionsfield ofGetBlockTemplatewhich hasn't changed since v17.Remove it.
Also remove an empty file left over from a previous change.