Reorder types structs in alphabetical order #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm surprised the last patch is so small, I read the PR description and expected an epic change set. I went to a fair bit of trouble to put all types in the same order as the method appears in the Core docs output (i.e., the rustdocs |
Two structs had incorrect RPC names in their rustdocs. Correct them.
Some of the structs and enums are not in alphabetical order. Order them all by the RPC name, with sub structs directly below. Code moves only, no content changes.
jamillambert
force-pushed
the
0909-types-alphabetical
branch
from
69628dc to
0ef4ea1
Compare
Collaborator
Author
|
Rebased on master. |
tcharding
approved these changes
Sep 10, 2025
Member
|
I edited the PR description to remove draft comment before I merged. |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
…order
0ef4ea1515e57082525cae1c760fea5a599c622c Reorder types structs and enums (Jamil Lambert, PhD)
3fc512d201555bacc883a9c8f06dd829e5eb47ae Fix RPC names in rustdocs (Jamil Lambert, PhD)
Pull request description:
Some of the structs and enums are not in alphabetical order.
- Order them all by the RPC name, with sub structs directly below. Code moves only, no content changes.
Two structs had incorrect RPC names in their rustdocs.
- Correct the rustdocs.
Draft because on top of #535. This PR is the last 2 patches.
ACKs for top commit:
tcharding:
ACK 0ef4ea1515e57082525cae1c760fea5a599c622c
Tree-SHA512: 6a416db121bb839a27c0e72a0ab44cc0856009dc73a3bb0ae1bdf77857c01255e8d0ad6ea23fe6b511d28986fbc3a3ff81cae1cc3613f1f6fcefd0c2a3e840e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the structs and enums are not in alphabetical order.
Two structs had incorrect RPC names in their rustdocs.