Use Self::Foo instead of importing error variants #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Error impl there is a combination of the use of: - use FooError::*; - use FooError as E; - Self::FooVariant Remove all imports and use Self::FooVariant in all Error impl in types.
Formatting change only, kept seperate to make diff or previous patch easier to read.
tcharding
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Error impl there is a combination of the use of:
Remove all imports and use Self::FooVariant in all Error impl in types. Style change only, there is no functional change.
Run the formatter in a separate patch to make the diff of the first easier to read.
Closes #372