-
Notifications
You must be signed in to change notification settings - Fork 40
Add support for Bitcoin Core 30.0 #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,197 @@ | ||
| // SPDX-License-Identifier: CC0-1.0 | ||
|
|
||
| //! A JSON-RPC client for testing against Bitcoin Core `v30`. | ||
| //! | ||
| //! We ignore option arguments unless they effect the shape of the returned JSON data. | ||
|
|
||
| use std::collections::BTreeMap; | ||
| use std::path::Path; | ||
|
|
||
| use bitcoin::address::{Address, NetworkChecked}; | ||
| use bitcoin::{sign_message, Amount, Block, BlockHash, PublicKey, Txid}; | ||
| use serde_json::json; | ||
|
|
||
| use crate::client_sync::into_json; | ||
| use crate::types::v30::*; | ||
|
|
||
| #[rustfmt::skip] // Keep public re-exports separate. | ||
| pub use crate::client_sync::{ | ||
| v17::{AddNodeCommand, ImportMultiRequest, ImportMultiScriptPubKey, ImportMultiTimestamp, Input, Output, SetBanCommand, WalletCreateFundedPsbtInput,}, | ||
| v21::ImportDescriptorsRequest, | ||
| v23::AddressType, | ||
| v29::{TemplateRequest, TemplateRules} | ||
| }; | ||
|
|
||
| crate::define_jsonrpc_minreq_client!("v30"); | ||
| crate::impl_client_check_expected_server_version!({ [300000] }); | ||
|
|
||
| // == Blockchain == | ||
| crate::impl_client_v29__dump_tx_out_set!(); | ||
| crate::impl_client_v17__get_best_block_hash!(); | ||
| crate::impl_client_v17__get_block!(); | ||
| crate::impl_client_v17__get_blockchain_info!(); | ||
| crate::impl_client_v17__get_block_count!(); | ||
| crate::impl_client_v19__get_block_filter!(); | ||
| crate::impl_client_v23__get_block_from_peer!(); | ||
| crate::impl_client_v17__get_block_hash!(); | ||
| crate::impl_client_v17__get_block_header!(); | ||
| crate::impl_client_v17__get_block_stats!(); | ||
| crate::impl_client_v26__get_chain_states!(); | ||
| crate::impl_client_v17__get_chain_tips!(); | ||
| crate::impl_client_v17__get_chain_tx_stats!(); | ||
| crate::impl_client_v23__get_deployment_info!(); | ||
| crate::impl_client_v29__get_descriptor_activity!(); | ||
| crate::impl_client_v17__get_difficulty!(); | ||
| crate::impl_client_v17__get_mempool_ancestors!(); | ||
| crate::impl_client_v17__get_mempool_descendants!(); | ||
| crate::impl_client_v17__get_mempool_entry!(); | ||
| crate::impl_client_v17__get_mempool_info!(); | ||
| crate::impl_client_v17__get_raw_mempool!(); | ||
| crate::impl_client_v17__get_tx_out!(); | ||
| crate::impl_client_v17__get_tx_out_proof!(); | ||
| crate::impl_client_v26__get_tx_out_set_info!(); | ||
| crate::impl_client_v24__get_tx_spending_prevout!(); | ||
| crate::impl_client_v26__import_mempool!(); | ||
| crate::impl_client_v17__precious_block!(); | ||
| crate::impl_client_v17__prune_blockchain!(); | ||
| crate::impl_client_v23__save_mempool!(); | ||
| crate::impl_client_v25__scan_blocks!(); | ||
| crate::impl_client_v17__verify_chain!(); | ||
| crate::impl_client_v17__verify_tx_out_proof!(); | ||
|
|
||
| // == Control == | ||
| crate::impl_client_v17__get_memory_info!(); | ||
| crate::impl_client_v18__get_rpc_info!(); | ||
| crate::impl_client_v17__help!(); | ||
| crate::impl_client_v17__logging!(); | ||
| crate::impl_client_v17__stop!(); | ||
| crate::impl_client_v17__uptime!(); | ||
|
|
||
| // == Generating == | ||
| crate::impl_client_v25__generate_block!(); | ||
| crate::impl_client_v17__generate_to_address!(); | ||
| crate::impl_client_v20__generate_to_descriptor!(); | ||
| crate::impl_client_v17__invalidate_block!(); | ||
|
|
||
| // == Hidden == | ||
| crate::impl_client_v21__add_peer_address!(); | ||
|
|
||
| // == Mining == | ||
| crate::impl_client_v17__get_block_template!(); | ||
| crate::impl_client_v17__get_mining_info!(); | ||
| crate::impl_client_v17__get_network_hashes_per_second!(); | ||
| crate::impl_client_v26__get_prioritised_transactions!(); | ||
| crate::impl_client_v17__prioritise_transaction!(); | ||
| crate::impl_client_v17__submit_block!(); | ||
| crate::impl_client_v18__submit_header!(); | ||
|
|
||
| // == Network == | ||
| crate::impl_client_v17__add_node!(); | ||
| crate::impl_client_v17__clear_banned!(); | ||
| crate::impl_client_v17__disconnect_node!(); | ||
| crate::impl_client_v17__get_added_node_info!(); | ||
| crate::impl_client_v26__get_addr_man_info!(); | ||
| crate::impl_client_v17__get_connection_count!(); | ||
| crate::impl_client_v17__get_net_totals!(); | ||
| crate::impl_client_v17__get_network_info!(); | ||
| crate::impl_client_v18__get_node_addresses!(); | ||
| crate::impl_client_v17__get_peer_info!(); | ||
| crate::impl_client_v17__list_banned!(); | ||
| crate::impl_client_v17__ping!(); | ||
| crate::impl_client_v17__set_ban!(); | ||
| crate::impl_client_v17__set_network_active!(); | ||
|
|
||
| // == Rawtransactions == | ||
| crate::impl_client_v18__analyze_psbt!(); | ||
| crate::impl_client_v17__combine_psbt!(); | ||
| crate::impl_client_v17__combine_raw_transaction!(); | ||
| crate::impl_client_v17__convert_to_psbt!(); | ||
| crate::impl_client_v17__create_psbt!(); | ||
| crate::impl_client_v17__create_raw_transaction!(); | ||
| crate::impl_client_v17__decode_psbt!(); | ||
| crate::impl_client_v17__decode_raw_transaction!(); | ||
| crate::impl_client_v17__decode_script!(); | ||
| crate::impl_client_v17__finalize_psbt!(); | ||
| crate::impl_client_v17__fund_raw_transaction!(); | ||
| crate::impl_client_v17__get_raw_transaction!(); | ||
| crate::impl_client_v18__join_psbts!(); | ||
| crate::impl_client_v17__send_raw_transaction!(); | ||
| crate::impl_client_v17__sign_raw_transaction!(); | ||
| crate::impl_client_v17__sign_raw_transaction_with_key!(); | ||
| crate::impl_client_v28__submit_package!(); | ||
| crate::impl_client_v17__test_mempool_accept!(); | ||
| crate::impl_client_v18__utxo_update_psbt!(); | ||
|
|
||
| // == Signer == | ||
| crate::impl_client_v22__enumerate_signers!(); | ||
|
|
||
| // == Util == | ||
| crate::impl_client_v17__create_multisig!(); | ||
| crate::impl_client_v29__derive_addresses!(); | ||
| crate::impl_client_v17__estimate_smart_fee!(); | ||
| crate::impl_client_v18__get_descriptor_info!(); | ||
| crate::impl_client_v21__get_index_info!(); | ||
| crate::impl_client_v17__sign_message_with_priv_key!(); | ||
| crate::impl_client_v17__validate_address!(); | ||
| crate::impl_client_v17__verify_message!(); | ||
|
|
||
| // == Wallet == | ||
| crate::impl_client_v17__abandon_transaction!(); | ||
| crate::impl_client_v17__abort_rescan!(); | ||
| crate::impl_client_v17__backup_wallet!(); | ||
| crate::impl_client_v17__bump_fee!(); | ||
| crate::impl_client_v23__create_wallet!(); | ||
| crate::impl_client_v28__create_wallet_descriptor!(); | ||
| crate::impl_client_v17__encrypt_wallet!(); | ||
| crate::impl_client_v17__get_addresses_by_label!(); | ||
| crate::impl_client_v17__get_address_info!(); | ||
| crate::impl_client_v17__get_balance!(); | ||
| crate::impl_client_v19__get_balances!(); | ||
| crate::impl_client_v28__get_hd_keys!(); | ||
| crate::impl_client_v18__get_received_by_label!(); | ||
| crate::impl_client_v17__get_new_address!(); | ||
| crate::impl_client_v17__get_raw_change_address!(); | ||
| crate::impl_client_v17__get_received_by_address!(); | ||
| crate::impl_client_v17__get_transaction!(); | ||
| crate::impl_client_v17__get_wallet_info!(); | ||
| crate::impl_client_v21__import_descriptors!(); | ||
| crate::impl_client_v17__import_pruned_funds!(); | ||
| crate::impl_client_v17__key_pool_refill!(); | ||
| crate::impl_client_v17__list_address_groupings!(); | ||
| crate::impl_client_v22__list_descriptors!(); | ||
| crate::impl_client_v18__list_received_by_label!(); | ||
| crate::impl_client_v17__list_labels!(); | ||
| crate::impl_client_v17__list_lock_unspent!(); | ||
| crate::impl_client_v17__list_received_by_address!(); | ||
| crate::impl_client_v17__list_since_block!(); | ||
| crate::impl_client_v17__list_transactions!(); | ||
| crate::impl_client_v17__list_unspent!(); | ||
| crate::impl_client_v18__list_wallet_dir!(); | ||
| crate::impl_client_v17__list_wallets!(); | ||
| crate::impl_client_v22__load_wallet!(); | ||
| crate::impl_client_v17__lock_unspent!(); | ||
| crate::impl_client_v24__migrate_wallet!(); | ||
| crate::impl_client_v21__psbt_bump_fee!(); | ||
| crate::impl_client_v17__remove_pruned_funds!(); | ||
| crate::impl_client_v17__rescan_blockchain!(); | ||
| crate::impl_client_v23__restore_wallet!(); | ||
| crate::impl_client_v21__send!(); | ||
| crate::impl_client_v24__send_all!(); | ||
| crate::impl_client_v17__send_many!(); | ||
| crate::impl_client_v21__send_many_verbose!(); | ||
| crate::impl_client_v17__send_to_address!(); | ||
| crate::impl_client_v17__set_tx_fee!(); | ||
| crate::impl_client_v19__set_wallet_flag!(); | ||
| crate::impl_client_v17__sign_message!(); | ||
| crate::impl_client_v17__sign_raw_transaction_with_wallet!(); | ||
| crate::impl_client_v24__simulate_raw_transaction!(); | ||
| crate::impl_client_v21__unload_wallet!(); | ||
| crate::impl_client_v17__wallet_create_funded_psbt!(); | ||
| crate::impl_client_v22__wallet_display_address!(); | ||
| crate::impl_client_v17__wallet_lock!(); | ||
| crate::impl_client_v17__wallet_passphrase!(); | ||
| crate::impl_client_v17__wallet_passphrase_change!(); | ||
| crate::impl_client_v17__wallet_process_psbt!(); | ||
|
|
||
| // == Zmq == | ||
| crate::impl_client_v17__get_zmq_notifications!(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Novel idea, increase this number so as not to have to make changes to the 4th oldest release. Are you planning on dropping this back to 3 or do you think we leave it as is for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see the reason to remove them? No effort to keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a policy thing, if we keep this and 27.x comes out we have to add support for it. Although this moving window has something annoying about it for downstream but I can't remember right now what it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I'm a goose, we have to anyway because we say we support the latest. hmmm not sure what to do, lets leave it until we think of something better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn't sure what effect removing 27.0 and 27.1 was on downstream. Mostly why I left them in.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment below says
# Only the latest minor version for older versions.which would suggest we have to anyway. I guess we don't want this for the older versions and should change the wording.EDIT: 😊 I see you wrote the same thing above.