Release tracking PR: jsonrpc v0.19.0
#408
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99c948c Re-implement json-using-serde feature (Tobin C. Harding) 1251953 Replace stale docs reference to minreq (Tobin C. Harding) Pull request description: This feature was removed when we gutted `minreq` after forking it. Turns out we need it to be able to use `bitreq` in `jsonrpc`. Re-implement the feature by copying code from `minreq`. Close: rust-bitcoin#393 ACKs for top commit: oleonardolima: tACK 99c948c jamillambert: ACK 99c948c Tree-SHA512: 2e22881566fd3d75e0edb70567dac0b1ed9ce66720511dcead888b2b7686fc89fb1f6bce3bd490f91997e9ade88b0665b00679c79bcef35205c6ce1117306faf
Stale name since we renamed the crate to `bitreq`. Fix a few instances of `s/minreq/bitreq` missed when forking.
Missed during crate rename.
We just forked `minreq` into this repository to create an HTTP crate that is specifically designed to be used by Bitcoin projects. As such we called it `bitreq`. Depend on the local `bitreq` crate instead of `minreq`. Done directly in `node` and `jsonrpc`. Indirectly in `client`, including rename of a million macros that have `minreq` in the name.
Remove the `minreq` changelog and add a changelog entry for the already released 0.1.0 Note I forgot to grab a commit hash when forking, that is a fail on my part.
I wrote this example stub when trying to add WASM support to the `minireq` fork (my first fork of `minreq` that was used as a basis of `bitreq`). It should never have been included in the crate import into this repo.
Put a dash between the version number and the date in all the changelog files where it is missing - woops.
In preparation for release bump the version number, add a changelog entry, and update the lock files. Also depend on the new version in all local crates.
Currently lists the repository name from before we did the `corepc` rename. Note this was never released, as such crates.io still points at Andrew's repo.
When we moved this crate from Andrew's repo somehow I forgot to bring over the `CHANGELOG.md` file. Copy it from the original repo (now archived). https://github.com/apoelstra/rust-jsonrpc/blob/master/CHANGELOG.md
In preparation for release bump the version number, add a changelog entry, and update the lock files.
|
Reviewed 52c02b3, all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because on top of #407