Implement TryFrom
#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
07-27-try-from
branch
from
d5d4a68 to
9373720
Compare
tcharding
force-pushed
the
07-27-try-from
branch
from
9373720 to
d85b78f
Compare
Member
Author
|
Changes in force push: Remove initial patch (which should never have been here). |
tcharding
force-pushed
the
07-27-try-from
branch
from
d85b78f to
8b4a7a1
Compare
Member
Author
|
Rebase and run formatter. |
tcharding
force-pushed
the
07-27-try-from
branch
from
8b4a7a1 to
9b46456
Compare
Member
Author
|
Rebase only, no other changes. |
tcharding
force-pushed
the
07-27-try-from
branch
from
9b46456 to
0c3059c
Compare
Member
Author
|
Rebase only, no other changes. |
Member
Author
|
Gentle bump, can I get a review please crew. |
Merged
Member
|
utACK 0c3059c but needs rebase. |
Now that we have MSRV 1.41.1 we can use `TryFrom`. Implement TryFrom<u8> for `u5` with the code that was in `try_from_u8`.
tcharding
force-pushed
the
07-27-try-from
branch
from
0c3059c to
bd651bb
Compare
Member
Author
|
Rebase only, no other changes. |
apoelstra
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have MSRV 1.41.1 we can use
TryFrom. Implement TryFrom foru5with the code that was intry_from_u8.