Skip to content

Conversation

@tcharding
Copy link
Member

@tcharding tcharding commented Feb 26, 2023

Add a CHANGELOG file including release notes for the current version (minor and point) as well as an "unrleased" section for the upcoming release.

cc benma

Close #83

Add a CHANGELOG file including release notes for the current
version (minor and point) as well as an "unrleased" section for the
upcoming release.
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK faa5229

Looks good to me. I don't understand the "woops" comment. What kind of release would you have us release non-breaking changes in?

@clarkmoody
Copy link
Member

ACK faa5229

@benma
Copy link

benma commented Feb 27, 2023

utACK faa5229

Looks good to me. I don't understand the "woops" comment. What kind of release would you have us release non-breaking changes in?

Afaik according to semver, in 0.y.z anything goes. Beyond 1.0.0, non-breaking changes that add functionality should bump the minor version.

You could consider going to 1.0.0 soon as the package is in use in production.

@apoelstra apoelstra merged commit 4411810 into rust-bitcoin:master Feb 27, 2023
@tcharding
Copy link
Member Author

Thanks @benma, I thought pre-1.0.0 we still were supposed to do a minor release (which is major because pre-1.0.0), the woops was because we did it in a patch release.

You could consider going to 1.0.0 soon as the package is in use in production.

That is top priority across the whole rust-bitcoin org at the moment. Specifically we are focusing on crate smashing to try and reduce the size of the crates to hasten the 1.0 release - no excuse for rust-bech32 though, we just have to get our shit together.

@tcharding tcharding deleted the 02-27-changelog branch February 27, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

please add a changelog

4 participants