Fix recent "alloc" feature fail #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
As the crate name suggests `with_allocator` requires the "alloc" feature to be enabled.
tcharding
force-pushed
the
03-01-fix-alloc
branch
6 times, most recently
from
764ffba to
d8c3bc6
Compare
Rework the github actions to fix the many bugs Tobin recently introduced. - Use dtolnay instead of actions-rs (non-embedded only) - Put fmt and clippy control into the CI script
tcharding
force-pushed
the
03-01-fix-alloc
branch
from
d8c3bc6 to
7873c85
Compare
Member
Author
|
Phew, that was harder than it should have been. |
apoelstra
approved these changes
Mar 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently in #71 I introduced a bucket load of bugs, in CI and in the
with-allocatorcrate (which was not being run correctly in CI).with-allocatorcrate.