Allow word count multiples of 3 instead of 6 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
word-counts
branch
2 times, most recently
from
46bf358 to
151816a
Compare
BIP39 says > The allowed size of ENT is 128-256 bits. Once we add the checksum this is 132-264 bits. This is divided by 11 to get the word count. From the BIP141 ``` CS = ENT / 32 MS = (ENT + CS) / 11 | ENT | CS | ENT+CS | MS | +-------+----+--------+------+ | 128 | 4 | 132 | 12 | | 160 | 5 | 165 | 15 | | 192 | 6 | 198 | 18 | | 224 | 7 | 231 | 21 | | 256 | 8 | 264 | 24 | ``` Currently we are limiting word count to be a multiple of 6, I do not know why this is being done but from reading the BIP it seems that 15 is a valid word count value. Allow word count of 15 by checking the word count modulo 3 instead of modulo 6. Since this check appears twice in the code, add a helper function to reduce code duplication. Fixes: rust-bitcoin#15
We just enabled word counts of 15, add a unit test that verifies all the valid word count values.
tcharding
force-pushed
the
word-counts
branch
from
151816a to
af958a2
Compare
Collaborator
|
tACK af958a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP39 says
Once we add the checksum this is 132-264 bits. This is divided by 11 to
get the word count. From the BIP
Currently we are limiting word count to be a multiple of 6, I do not
know why this is being done but from reading the BIP it seems that 15 is
a valid word count value.
Allow word count of 15 by checking the word count modulo 3 instead of
modulo 6.
Fixes: #15