Manually print InvalidChecksum
#4889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
push-wrnqqxlsxymo
branch
from
3a460f9 to
a0670fc
Compare
Done in preparation for patching the `Display` impl of `ParseError` to manually print hex. Add a regression test.
Currently the `ParseError` is a mess. The correct fix is likely to use an associated type in `Decodable` for the error but that can wait. Right now we are using `hex` in the `Display` impl for `ParseError`. This will cause trouble when we move the error type to `consenus_encoding` because `hex` is a feature. Just manually print hex characters by accessing the array. Logic is already tested with a static string, this patch does not change the output.
tcharding
force-pushed
the
push-wrnqqxlsxymo
branch
from
a0670fc to
cde4736
Compare
|
Good eye, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
ParseErroris a mess. The correct fix is likely to use an associated type inDecodablefor the error but that can wait.Right now we are using
hexin theDisplayimpl forParseError. This will cause trouble when we move the error type toconsenus_encodingbecausehexis a feature. Even if we do not do so this code is a mainitenance burden.Just manually print hex characters by accessing the array. Logic is already tested with a static string, this patch does not change the output.