Add hashes and chacha20_poly1305 to criterion benches crate
#5012
Conversation
github-actions
bot
added
C-bitcoin
| Run all benchmarks in this crate: | ||
|
|
||
| ```bash | ||
| cargo bench |
There was a problem hiding this comment.
If I remember, this requires the nightly toolchain which would be worth a mention. Or you could do cargo +nightly bench here I think.
There was a problem hiding this comment.
I added a section stating that the MSRV is 1.81 due to the dependency on criterion. I did try to get it to work on 1.74.0, but didn't manage in a reasonable amount of time and assumed it wasn't important since the benches only ran on nightly before.
There was a problem hiding this comment.
Oops, it's libfuzzer that requires nightly, not criterion. Sorry, I redact the previous comment.
There was a problem hiding this comment.
Yeah, as long as something's in the top-level workspace.exclude we can require pretty-much anything.
I do think it's possible to get an old version of criterion that works with 1.74, but agree that it's not particularly urgent.
Add a readme file to describe how to use the new benches crate.
Move all of the bench code to individual files in hashes/benches/ Add Criterion as a dependency in Cargo.toml
Move all of the bench code to individual files in chacha20_poly1305/benches/ Add Criterion as a dependency in Cargo.toml
jamillambert
force-pushed
the
0919-criterion-hashes-chacha
branch
from
96dfc80 to
aeb6027
Compare
3 participants
All the benchmarking for this repo is being moved to use
criterion.README.mdfor the crate.hashesbenchmarks tobencheschacha20_poly1305benchmarks tobenches