units: Improve the decoders #5027
Conversation
|
cc @nyonson, I know you are watching but just to be sure. |
tcharding
force-pushed
the
push-sytnloquurnn
branch
from
c0448f8 to
672c08a
Compare
tcharding
changed the title
tcharding
force-pushed
the
push-sytnloquurnn
branch
from
672c08a to
96908b3
Compare
| } | ||
|
|
||
| #[cfg(feature = "encoding")] | ||
| impl From<encoding::UnexpectedEofError> for AmountDecoderError { |
There was a problem hiding this comment.
New pattern for me here so might be missing something, but would this From impl still be useful if updates to the new constructor?
There was a problem hiding this comment.
The reason for removing this is that if we keep it we have to commit to it, so we cannot stop using the UnexpectedEofError. As much as this is unlikely I'm trying to be as conservative as possible and since the from impl is only used internally there is no need for it other than ergonomics (in internal code). Also downstream should never be constructing AmountDecoderError.
There was a problem hiding this comment.
Got it, thanks for the explanation. Wasn't obvious to me how the From was part of the exported API.
tcharding
force-pushed
the
push-sytnloquurnn
branch
from
a2cac48 to
c3c49a9
Compare
Introduces new policy on how we implement decoder error types. - All internals are hidden - No `From<OtherError>` impls - Private constructors - Inner enum is private (does not need non_exhaustive).
If two encoders return the same error it is not currently possible to compose them with our decoders. Having a new type instead of returning the `UnexpectedEofError` makes this possible (assuming one doesn't want to compose two decoders of the same type).
So the decoders can be used by downstream add constructors for them all. Also implement `Default` for the decoder types.
tcharding
force-pushed
the
push-sytnloquurnn
branch
from
c3c49a9 to
d340c4d
Compare
As we do for other `signed` and `unsigned` types; re-export the `AmountDecoder` from the `amount` module.
|
You need another API run after the last commit. |
|
But utACK 6175586 |
3 participants
Improve all the decoders and decoder error types in
units. Based on recent discussion.This PR introduces policy on how we implement decoder error types (patch 1 and 2).
LFG, decoders done by Nashville!