Skip to content

Refactoring env var case convert to convert each segment between separator#746

Closed
11alieberman wants to merge 1 commit into
rust-cli:mainfrom
11alieberman:fix-env-case-convert
Closed

Refactoring env var case convert to convert each segment between separator#746
11alieberman wants to merge 1 commit into
rust-cli:mainfrom
11alieberman:fix-env-case-convert

Conversation

@11alieberman
Copy link
Copy Markdown

Currently, it looks like when you are parsing the environment variables into the config and you have some key with multiple segments separated by the ., (key1.key2.key3) when you do the case convert for a case like Pascal, it will result in (Key1.key2.key3). I am not sure if this is intended, because I would think the result should be (Key1.Key2.Key3), where each segment is individually case converted.

This PR aims to refactor the case conversion to convert each segment and not just the first segment.

Also aims to address #693

@11alieberman
Copy link
Copy Markdown
Author

@epage Would you have time to take a look at this?

@epage
Copy link
Copy Markdown
Contributor

epage commented Mar 23, 2026

This claims to be a refactor but claims to address #693 which would mean there is user-facing changes and so this wouldn't be a refactor anymore.

The linked issue's status is S-triage. In general, we don't look at PRs and discourage the submission of them unless there is agreement on the problem and the proposed solution, see https://github.com/rust-cli/config-rs/blob/main/CONTRIBUTING.md#pull-requests

As such, I'm leaning towards closing this, not as a statement about what this PR does but that this is not the appropriate stage to be looking at code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants