Skip to content

Extend multipart and media-type handling across clients#118

Merged
adamcavendish merged 1 commit into
masterfrom
adamcavendish/multipart-more-languages
Jun 15, 2026
Merged

Extend multipart and media-type handling across clients#118
adamcavendish merged 1 commit into
masterfrom
adamcavendish/multipart-more-languages

Conversation

@adamcavendish

@adamcavendish adamcavendish commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Extends multipart/form-data request-body generation for Go, Java OkHttp, Kotlin OkHttp, Python httpx/requests, and TypeScript fetch clients.
  • Aligns request and response media-type selection for JSON, +json, text, and binary payloads, including exact +json content types.
  • Guards optional multipart bodies and reports unsupported non-JSON body encodings explicitly.

Tests

  • just ci
  • ./scripts/golden-build-go.sh
  • ./scripts/golden-build-java.sh
  • ./scripts/golden-build-kotlin.sh
  • ./scripts/golden-build-python.sh httpx
  • ./scripts/golden-build-python.sh requests
  • ./scripts/golden-build-rust.sh aioduct
  • ./scripts/golden-build-rust.sh reqwest
  • ./scripts/golden-build-rust.sh ureq
  • ./scripts/golden-build-typescript.sh vp
  • TypeScript generated-client tsc build with a temporary local TypeScript install

Clients:
- Generate multipart bodies for Go, Java, Kotlin, Python, and TypeScript clients
- Select exact request and response media types for JSON, +json, text, and binary payloads
- Guard optional multipart bodies and report unsupported encodings explicitly

Tests:
- Add desensitized multipart edge-case, nested-part, and media-selection fixtures
- Add runtime smoke checks for wire construction and serialization choices
- Regenerate goldens across affected generator suites
@adamcavendish adamcavendish force-pushed the adamcavendish/multipart-more-languages branch from 49fb068 to ede7b80 Compare June 15, 2026 04:30
@adamcavendish adamcavendish changed the title Fix multipart request bodies for non-Rust clients Extend multipart and media-type handling across clients Jun 15, 2026
@adamcavendish adamcavendish marked this pull request as ready for review June 15, 2026 04:31
@adamcavendish adamcavendish merged commit 0e0c089 into master Jun 15, 2026
24 checks passed
@adamcavendish adamcavendish deleted the adamcavendish/multipart-more-languages branch June 15, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant